wcmolin commented on code in PR #18608:
URL:
https://github.com/apache/dolphinscheduler/pull/18608#discussion_r3901945304
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/TaskForceSuccessStateAction.java:
##########
@@ -27,6 +29,13 @@
@Component
public class TaskForceSuccessStateAction extends TaskSuccessStateAction {
+ @Override
+ protected void persistentTaskInstanceSuccessEventToDB(final ITaskExecution
taskExecution,
Review Comment:
Added a Master integration test in
`WorkflowInstanceRecoverFailureTaskTestCase`.
The scenario initializes a failed serial workflow where task A is
`FORCED_SUCCESS` and task B is `FAILURE`, recovers failed tasks through
`workflowOperator.recoverFailureTasks`, and verifies:
- task A remains `FORCED_SUCCESS`;
- the failed B instance is disabled and B reruns successfully;
- the workflow finishes successfully with `runTimes = 2`.
Verified with JDK 8; the 115-module reactor build and the new integration
test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
