ruanwenjun commented on code in PR #18585:
URL:
https://github.com/apache/dolphinscheduler/pull/18585#discussion_r3974711462
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RunWorkflowCommandHandler.java:
##########
@@ -126,14 +124,8 @@ private String mergeCommandParamsWithWorkflowParams(final
Command command,
.orElse(null);
final List<Property> globalParamsList =
GlobalParameterUtils.deserializeGlobalParameter(workflowDefinition.getGlobalParams());
- Map<String, Property> finalParams = new HashMap<>();
- if (CollectionUtils.isNotEmpty(globalParamsList)) {
- globalParamsList.forEach(globalParam ->
finalParams.put(globalParam.getProp(), globalParam));
- }
- if (CollectionUtils.isNotEmpty(commandParams)) {
- commandParams.forEach(commandParam ->
finalParams.put(commandParam.getProp(), commandParam));
- }
- return JSONUtils.toJsonString(finalParams.values());
+ return JSONUtils.toJsonString(
Review Comment:
It's better to replace the sensitive mask value at api server, master don't
need to care about this, we don't store `******` at DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
