goutamadwant opened a new pull request, #18639:
URL: https://github.com/apache/dolphinscheduler/pull/18639

   ## Was this PR generated or assisted by AI?
   
   YES. AI assisted with understanding the existing codebase, reviewing the 
code, and local validation.
   
   ## Purpose of the pull request
   
   Related to #16390.
   
   The Worker template already supports additional volumes and volume mounts, 
but the API template ignores equivalent values. This prevents operators from 
supplying Hadoop XML configuration consistently to both components through the 
chart.
   
   This PR adds the missing API options and documents using an existing 
ConfigMap to mount `core-site.xml` and `hdfs-site.xml` into API and Worker 
containers.
   
   ## Brief change log
   
   - Render `api.extraVolumes` and `api.extraVolumeMounts` using the existing 
Worker pattern.
   - Add empty defaults and document both components' options.
   - Document individual read-only XML mounts, image-specific configuration 
paths, and the required pod restart after ConfigMap updates.
   - Regenerate the chart README using the repository's pinned generator.
   
   ## Verify this pull request
   
   Manually verified locally:
   
   - `./mvnw spotless:apply`.
   - `./mvnw spotless:check`.
   - `./mvnw validate -P helm-doc -pl :dolphinscheduler`.
   - Strict Helm 3 lint and rendering with all pinned chart dependencies.
   - Default workload manifests remain unchanged.
   - Documented mounts render correctly, including when API persistent storage 
and custom configuration are enabled.
   - Disabled API and Worker components emit no workloads.
   - Strict Kubernetes 1.31 schema validation: 29 valid resources.
   - Hadoop configuration probes in pinned API and Worker images load the XML 
settings with mounts; negative controls fail without them.
   
   These are local checks; no regression test framework was added to the 
repository. Live Kubernetes deployment, HDFS resource operations, failover, and 
Kerberos were not tested. This change supplies configuration mounts for an 
already configured HDFS deployment. The existing common-properties mount-path 
discrepancy is outside this change.
   
   ## Pull Request Notice
   
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   No incompatible change: the new options default to empty lists, preserving 
existing default workload manifests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to