eye-gu commented on issue #18600: URL: https://github.com/apache/dolphinscheduler/issues/18600#issuecomment-5678090728
@SbloodyS Thanks for the feedback. Let me keep it simple and state the scope clearly: The datasource SPI contract stays as it is. The only change is the type identifier — DbType becomes a String — nothing else in the contract changes. Most importantly, non-JDBC datasource plugins such as SSH and K8s remain unchanged — same implementation, same behavior, same registration. They already work under this contract today; the only mechanical touch is the identifier's return type. That is exactly the point: the contract does not need an abstraction change for this proposal. A custom datasource plugin — JDBC or not — brings its own implementation; what this DSIP removes is only the compile-time enum that prevents an outside plugin from introducing a new type instead of just overriding a built-in one. Does that address your concern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
