det101 opened a new pull request, #18649:
URL: https://github.com/apache/dolphinscheduler/pull/18649

   ## Was this PR generated or assisted by AI?
   
   YES. Cursor assisted with root-cause analysis from CI logs, the page-object 
wait change, and this description. AI assistance does not replace maintainer 
review.
   
   是。Cursor 协助了从 CI 日志定位根因、Page Object wait 修改以及本文说明。AI 协助不替代维护者审阅。
   
   ## Purpose of the pull request
   
   Fixes #18646.
   
   Datasource E2E cases (notably `DolphinDBDataSourceE2ETest`) flake when 
`DataSourcePage#createDataSource` eagerly calls `driver.findElement(...)` 
before `WebDriverWait`. A slow create-dialog mount then throws 
`NoSuchElementException` within ~1s instead of using the 10s explicit wait.
   
   This change waits via locators (`elementToBeClickable(By)` / 
`textToBePresentInElementLocated`) so presence is part of the wait condition. 
Product UI behavior is unchanged.
   
   ## Brief change log
   
   - Wait for the datasource type box with 
`ExpectedConditions.elementToBeClickable(By)`.
   - Wait for the create dialog with 
`ExpectedConditions.textToBePresentInElementLocated(...)`.
   
   ## Verify this pull request
   
   - Diff-only change in shared page object; no product code.
   - Relies on CI E2E matrix for datasource jobs (DolphinDB / MySQL / Postgres 
/ etc.).
   
   ## Pull Request Notice
   
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to