hiSandog opened a new pull request, #18651:
URL: https://github.com/apache/dolphinscheduler/pull/18651

   ## Was this PR generated or assisted by AI?
   
   YES. OpenAI Codex assisted with the fix, regression tests, and validation.
   
   ## Purpose of the pull request
   
   Fixes #18642.
   
   `AbsStorageOperator.getStorageBaseDirectory()` calls itself recursively, so 
resolving an ABS resource directory throws `StackOverflowError`. Read the 
inherited `resourceBaseAbsolutePath` instead, preserving the existing 
leading-slash normalization used by the other object-storage plugins.
   
   ## Brief change log
   
   - Replace the recursive calls with the configured base path.
   - Add tests for paths with and without a leading slash and for 
tenant/resource directory resolution. Azure clients are mocked, so no cloud 
account is required.
   
   ## Verify this pull request
   
   All three tests reproduce `StackOverflowError` before the fix and pass after 
it. Validation used Java 8 and the repository's Maven wrapper:
   
   ```sh
   ./mvnw -B -pl dolphinscheduler-storage-plugin/dolphinscheduler-storage-abs 
spotless:apply
   ./mvnw -B -pl dolphinscheduler-storage-plugin/dolphinscheduler-storage-abs 
-am -Dtest=AbsStorageOperatorTest -Dsurefire.failIfNoSpecifiedTests=false clean 
test
   ```
   
   The test build also runs Spotless checks. `git diff --check` passes.
   
   ## Pull Request Notice
   
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to