yykaue commented on issue #18402:
URL:
https://github.com/apache/dolphinscheduler/issues/18402#issuecomment-5727790726
Thanks @SbloodyS for the feedback on #18654. I jumped into the PR too early.
I'd like to work out the approach here first before updating it.
The idea is to let users search for a task name within a project and open
the workflow that owns it. This would use task definitions, so it would also
find tasks that have never run or whose instances have been cleaned up. It
would stay read-only and use the existing project read permissions.
There are three decisions I would like to discuss:
1. **Search behavior and performance**
I agree that `LIKE '%keyword%'` raises a performance concern. Existing
uses of this pattern elsewhere do not establish that it is suitable for this
query. Project scoping and pagination also do not guarantee an inexpensive
query, especially when counting distinct results.
Is substring matching required for the first version, or would
exact/prefix matching be acceptable? Once the matching semantics are agreed
upon, I can provide MySQL and PostgreSQL execution plans and benchmarks on
representative large-project data, including the count query, to evaluate
whether index changes are needed.
2. **UI entry point**
The issue proposes a lightweight Task Search page next to Task Instance.
Would maintainers prefer this entry point, or a task-name filter within the
existing Workflow Definition page?
The functionality would remain read-only and preserve the
workflow-centered model introduced by DSIP-59.
3. **Task version semantics**
I propose searching the task versions referenced by current workflow
definitions. For example, if a current workflow references task version 1 while
version 2 exists, the result would show the name from version 1 so that it
matches the linked workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
