github-advanced-security[bot] commented on code in PR #18661:
URL:
https://github.com/apache/dolphinscheduler/pull/18661#discussion_r4068606697
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/listener/WorkflowSuccessLifecycleListener.java:
##########
@@ -47,10 +49,18 @@
@Autowired
private WorkflowBackfillTrigger workflowBackfillTrigger;
+ @Autowired
+ private WorkflowInstanceDao workflowInstanceDao;
+
@Override
public void notifyWorkflowLifecycleEvent(final IWorkflowExecution
workflowExecution,
final
AbstractWorkflowLifecycleLifecycleEvent lifecycleEvent) {
final WorkflowInstance workflowInstance =
workflowExecution.getWorkflowInstance();
+ if (workflowInstance.getNextWorkflowInstanceId() > 0
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [WorkflowInstance.getNextWorkflowInstanceId](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5863)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/listener/WorkflowSuccessLifecycleListener.java:
##########
@@ -99,12 +109,17 @@
workflowBackfillTrigger.triggerWorkflow(backfillTriggerRequest);
if (!backfillTriggerResponse.isSuccess()) {
log.warn("Backfill workflow failed: {}",
backfillTriggerResponse.getMessage());
+ } else {
+
workflowInstance.setNextWorkflowInstanceId(backfillTriggerResponse.getWorkflowInstanceId());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [WorkflowInstance.setNextWorkflowInstanceId](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5864)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
