chovy-3012 opened a new pull request, #18681: URL: https://github.com/apache/dolphinscheduler/pull/18681
## Was this PR generated or assisted by AI? NO. ## Purpose of the pull request Fix Shell task documentation inconsistencies between Chinese and English versions, grammar errors, missing appendix rows, and a parameter validation gap where whitespace-only scripts pass `checkParameters()`. ## Brief change log - `docs/docs/zh/guide/task/shell.md`: Add missing parameter table; add note for deprecated `ResourceInfo.id` and `res` fields - `docs/docs/en/guide/task/shell.md`: Fix 4 grammar errors; add note for deprecated fields - `docs/docs/en/guide/task/appendix.md`: Add missing `Cache Execution` and `Group Priority` rows - `ShellParameters.java`: `checkParameters()` use `trim()` to reject whitespace-only scripts - `ShellParametersTest.java`: Add 4 unit tests for `checkParameters()` ## Verify this pull request This change added tests and can be verified as follows: - Added `ShellParametersTest.checkParametersTest_whitespaceOnlyRawScript` to verify whitespace-only scripts are rejected after `trim()` fix - Added `checkParametersTest_nullRawScript`, `checkParametersTest_emptyRawScript`, `checkParametersTest_validRawScript` to cover all branches - All 13 tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
