kittimzhe commented on issue #18696:
URL:
https://github.com/apache/dolphinscheduler/issues/18696#issuecomment-6159613546
Confirmed the mechanism — `HttpTask#sendDeleteRequest`
(dolphinscheduler-task-http/.../HttpTask.java:193-203) never collects the
request parameters at all:
```java
private OkHttpResponse sendDeleteRequest() {
...
OkHttpResponse okHttpResponse =
OkHttpUtils.delete(httpParameters.getUrl(), okHttpRequestHeaders,
httpParameters.getConnectTimeout(), ...);
```
Compare `sendGetRequest` (:149-158), which passes `getRequestParams()`
through to `OkHttpUtils.get`, where `addUrlParams` appends them to the URL. The
`delete` overloads (`OkHttpUtils.java:249-279`) take no parameter map, so
PARAMETER-typed HTTP Parameters are silently dropped for DELETE — matching your
repro (`DELETE /capture?existing=1` with `jobId` lost, while GET sends it).
Claiming this. Fix shape: a `delete` overload that accepts the parameter map
and runs it through the same `addUrlParams` the GET path uses, plus
`sendDeleteRequest` collecting `getRequestParams()` like GET does — so `DELETE
/capture?existing=1` + `jobId=42` sends `?existing=1&jobId=42`, consistent with
the HTTP task docs describing the parameters as GET/DELETE request parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
