SbloodyS commented on code in PR #18705:
URL: 
https://github.com/apache/dolphinscheduler/pull/18705#discussion_r4278413706


##########
deploy/kubernetes/dolphinscheduler/README.md:
##########
@@ -206,6 +206,7 @@ The paths above match the API and Worker server classpaths. 
Check the configurat
 | conf.common."sql.task.alert.max.content.bytes" | int | `60000` | max 
serialized UTF-8 bytes of the SQL task-result alert content, kept below the 
65535-byte capacity of the MySQL TEXT column |
 | conf.common."sql.task.alert.max.row.value.length" | int | `100` | max chars 
of a single string value kept in the SQL task-result alert content, longer 
values are truncated with an ellipsis |
 | conf.common."sql.task.alert.max.rows" | int | `30` | max rows kept in the 
SQL task-result alert content, rows beyond this are replaced by an omission 
marker |
+| conf.common."sql.task.query.max.rows" | int | `10000` | max rows fetched 
from the datasource when the SQL task-level "limit" parameter is not set |

Review Comment:
   Please provide this parameter to the user in the UI of the task definition, 
which I think is meaningless here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to