det101 commented on PR #18706:
URL:
https://github.com/apache/dolphinscheduler/pull/18706#issuecomment-6210631187
Verified end-to-end on a standalone instance (official 3.4.3 image + this
branch's jars + rebuilt UI), with a SHELL task carrying `secret_token`
(sensitive) and `normal_msg` (normal) prepareParams:
| Log location | Result |
|---|---|
| Task log: localParams JSON / Final Script Content | `value: "******"` ✅ |
| Task log: **process output** | plaintext `SuperSecretToken123` kept, per
review intent ✅ |
| Worker log: `Initialized Task Context{...}` dump (taskParams +
prepareParamsMap) | `******`, MDC `[TI-1]` ✅ |
| Normal params | never masked, no over-masking ✅ |
During this E2E run I also found a **pre-existing** leak unrelated to this
PR's changes: `PhysicalTaskExecutorOperatorImpl` (introduced in #16790) logged
the whole `TaskExecutorDispatchRequest` on the RPC dispatch thread — *before*
per-task masks are registered and without `taskInstanceId` MDC, so both masking
mechanisms missed it. Fixed in 48c469ea by logging only `taskInstanceId` and
`taskName`; after the fix the worker log contains no sensitive plaintext
outside the process-output forwarding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
