yangyichao-mango commented on a change in pull request #3235:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3235#discussion_r456765468
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java
##########
@@ -152,6 +152,7 @@ public void unRegistry() {
// trim and lower case is need
workerZkPathBuilder.append(workGroup.trim().toLowerCase()).append(SLASH);
workerZkPathBuilder.append(address);
+ workerZkPathBuilder.append(weight).append(SLASH);
Review comment:
Hi,
If user choose to use `RoundRobinSelector`, there will be no need to add the
`weight` to zk heartbeat info. Maybe we can design this feature better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
