khadgarmage commented on a change in pull request #3291:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3291#discussion_r459376734
##########
File path: docker/build/Dockerfile
##########
@@ -1,82 +1,49 @@
-#
Review comment:
why delete the license header?
##########
File path: docker/build/hooks/build
##########
@@ -38,16 +38,8 @@ echo "Repo: $DOCKER_REPO"
echo -e "Current Directory is $(pwd)\n"
-# maven package(Project Directory)
-echo -e "mvn -B clean compile package -Prelease -Dmaven.test.skip=true"
-mvn -B clean compile package -Prelease -Dmaven.test.skip=true
-
-# mv dolphinscheduler-bin.tar.gz file to docker/build directory
-echo -e "mv
$(pwd)/dolphinscheduler-dist/target/apache-dolphinscheduler-incubating-${VERSION}-dolphinscheduler-bin.tar.gz
$(pwd)/docker/build/\n"
-mv
$(pwd)/dolphinscheduler-dist/target/apache-dolphinscheduler-incubating-${VERSION}-dolphinscheduler-bin.tar.gz
$(pwd)/docker/build/
-
# docker build
-echo -e "docker build --build-arg VERSION=${VERSION} -t
$DOCKER_REPO:${VERSION} $(pwd)/docker/build/\n"
-sudo docker build --build-arg VERSION=${VERSION} -t $DOCKER_REPO:${VERSION}
$(pwd)/docker/build/
+echo -e "docker build -f docker/build/Dockerfile -t $DOCKER_REPO:${VERSION}
$(pwd)\n"
Review comment:
alter the path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
