CalvinKirs commented on a change in pull request #3402:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3402#discussion_r467713818
##########
File path:
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/threadutils/ThreadUtilsTest.java
##########
@@ -77,13 +77,12 @@ public void run() {
start.add(Calendar.SECOND, 1);
globalTimer.add(Calendar.SECOND, 1);
}
- System.out.println("time is " + System.currentTimeMillis());
}
};
scheduleService.scheduleAtFixedRate(schedulerTask, 2, 10,
TimeUnit.SECONDS);
assertFalse(scheduleService.isShutdown());
try {
- Thread.sleep(60000);
+ Thread.sleep(2000);
Review comment:
Sleep is not recommended in the test code, maybe we should try to use
Awaitility to achieve the same effect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
