vanilla111 commented on a change in pull request #3427:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3427#discussion_r467826363
##########
File path:
dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/codec/NettyDecoder.java
##########
@@ -55,15 +55,18 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf
in, List<Object> out) t
case MAGIC:
checkMagic(in.readByte());
checkpoint(State.COMMAND);
+ break;
case COMMAND:
commandHeader.setType(in.readByte());
checkpoint(State.OPAQUE);
+ break;
case OPAQUE:
commandHeader.setOpaque(in.readLong());
checkpoint(State.BODY_LENGTH);
case BODY_LENGTH:
commandHeader.setBodyLength(in.readInt());
checkpoint(State.BODY);
+ break;
Review comment:
> You cannot directly break here, please refer to #3035
I know the reason for removing break. Should I add a break at the last case?
If don't do this, there will be many WARN logs that shouldn't appear in the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
