hsupu commented on a change in pull request #3442:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3442#discussion_r468377685
##########
File path:
dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/DependentTaskTest.java
##########
@@ -37,188 +45,426 @@
import org.slf4j.LoggerFactory;
import org.springframework.context.ApplicationContext;
-import java.util.ArrayList;
-import java.util.Date;
-import java.util.List;
-
@RunWith(MockitoJUnitRunner.Silent.class)
Review comment:
I found it's necessary to use the "Slient" one here. For other tests
raised problems and leaded `Stopper.isRunning() == false`.
Then the mockito treated some mock as unused (because not invoked by code
inside the branch of `Stopper.isRunning() == true`) and triggered
`UnnecessaryStubbingException`.
All things unusual leads to the unit test build of the PR failed. Wired but
not involved in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
