yangyichao-mango commented on issue #3471: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3471#issuecomment-672571272
1. For JsonUitls.toMap(), I think it is necessary to check whether the string is empty before use jsonUtils according to the fail-fast mode, and the null judge in jsonUtils is just the second protect from NPE. We can not just rely on the jsonUtils null check. 2.Method name checkstyle +1. If you want to improve it, welcome to leave a message. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
