lgcareer commented on a change in pull request #3514:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3514#discussion_r472882004
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java
##########
@@ -860,7 +846,7 @@ public Result onlineCreateResource(User loginUser,
ResourceType type, String fil
// save data
Date now = new Date();
Resource resource = new
Resource(pid,name,fullName,false,desc,name,loginUser.getId(),type,content.getBytes().length,now,now);
-
+ //TODO confirm need to check the success status?
resourcesMapper.insert(resource);
Review comment:
I think not necessary,because here should not be the error status
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
