SunJiFengPlus commented on issue #3556: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3556#issuecomment-677670233
I will be willing to do this. Before i am doing this, I want you to confirm the unit test cases I need to write. <img width="400" alt="截屏2020-08-20 21 00 08" src="https://user-images.githubusercontent.com/39667700/90773282-3d9b3400-e328-11ea-86c3-e82b087cfa29.png";> I use the following test case to cover the yellow(current unit test case not all hit) and red(current unit test case not hit) lines: 1. param without stateType 2. param without startDate 3. param without endDate 4. param startDate with illegal format 5. param startDate with illegal format 6. both 4 and 5 May be i can use only one unit test case to cover this, I'm not sure which one is better. Finally I have a question, Why put so many unit test cases into one method? As i am concerned, i'd like to place each unit test in one method., then named the method with "given_xxx_when_xxx_then_xxx" or comment with "given xxx when xxx then xxx". When [regression testing | CI] running fail, i can locate cause of unit test case instead of method name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/39667700/90773282-3d9b3400-e328-11ea-86c3-e82b087cfa29.png"](https://user-images.githubusercontent.com/39667700/90773282-3d9b3400-e328-11ea-86c3-e82b087cfa29.png"){kind=link}