yangyichao-mango commented on a change in pull request #3559:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3559#discussion_r474369948
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/utils/EnterpriseWeChatUtils.java
##########
@@ -48,8 +55,8 @@
private static final String ENTERPRISE_WE_CHAT_TOKEN_URL =
PropertyUtils.getString(Constants.ENTERPRISE_WECHAT_TOKEN_URL);
private static final String ENTERPRISE_WE_CHAT_TOKEN_URL_REPLACE =
ENTERPRISE_WE_CHAT_TOKEN_URL == null ? null : ENTERPRISE_WE_CHAT_TOKEN_URL
- .replaceAll("\\{corpId\\}", ENTERPRISE_WE_CHAT_CORP_ID)
- .replaceAll("\\{secret\\}", ENTERPRISE_WE_CHAT_SECRET);
+ .replaceAll("\\{corpId\\}", ENTERPRISE_WE_CHAT_CORP_ID)
+ .replaceAll("\\{secret\\}", ENTERPRISE_WE_CHAT_SECRET);
Review comment:
```suggestion
.replaceAll("\\{corpId}", ENTERPRISE_WE_CHAT_CORP_ID)
.replaceAll("\\{secret}", ENTERPRISE_WE_CHAT_SECRET);
```
Please change the other part of `replaceAll`.
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/ZookeeperNodeManager.java
##########
@@ -38,33 +35,37 @@
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
-import static
org.apache.dolphinscheduler.common.Constants.DEFAULT_WORKER_GROUP;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
/**
- * zookeeper node manager
+ * zookeeper node manager
Review comment:
Is this file changes related with this pr?
If not related, please revert.
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AlertWarnLevel.java
##########
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.enums;
+
+public enum AlertWarnLevel {
+
+ MIDDLE,SERIOUS
Review comment:
Is it better to match the logger?
For excample: debug, info, warning, error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
