felix-thinkingdata commented on pull request #3743: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692451479
ok i see😅😅😅发自我的iPhone------------------ Original ------------------From: geosmart <[email protected]>Date: Tue,Sep 15,2020 9:19 AMTo: apache/incubator-dolphinscheduler <[email protected]>Cc: felix.wang <[email protected]>, Comment <[email protected]>Subject: Re: [apache/incubator-dolphinscheduler] [FEATURE-736] integrate ldapauthentication (#3743) dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/AbstractAuthenticator.java Is this abstraction necessary? 这种抽象有没有必要？ if I don't refactor a AbstractAuthenticator , sonar will detect the duplicate and can not pass... —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe. [ { "@context": "http://schema.org";, "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838";, "url": "https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838";, "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com"; } } ] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
