Technoboy- commented on a change in pull request #3748:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3748#discussion_r489279826
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/NettyRemoteChannel.java
##########
@@ -43,13 +45,21 @@
*/
private final Host host;
+ private final Random random = new Random();
+
public NettyRemoteChannel(Channel channel, long opaque) {
this.channel = channel;
this.host = ChannelUtils.toAddress(channel);
this.opaque = opaque;
}
+ public NettyRemoteChannel(Channel channel) {
+ this.channel = channel;
+ this.host = ChannelUtils.toAddress(channel);
+ this.opaque = random.nextLong();
Review comment:
opaque should be -1 is much better. we can locate the issue easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
