CalvinKirs commented on a change in pull request #3880:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3880#discussion_r502761934
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -168,14 +168,14 @@
select *
from t_ds_process_instance
where 1=1
+ and process_definition_id=#{processDefinitionId}
Review comment:
Hi, is it possible to delete this statement?
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -168,14 +168,14 @@
select *
from t_ds_process_instance
where 1=1
+ and process_definition_id=#{processDefinitionId}
Review comment:
Hi, 1=1 is it possible to delete this statement?
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -168,14 +168,14 @@
select *
from t_ds_process_instance
where 1=1
Review comment:
Hi, is it possible to delete this statement?
##########
File path:
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -168,14 +168,14 @@
select *
from t_ds_process_instance
where 1=1
Review comment:
Hi, 1=1 ,is it possible to delete this statement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
