[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #3918: [fix-#3843][api]When update workflow definition,if name already exists, the prompt is not friendly

Thu, 15 Oct 2020 20:23:24 -0700 


zhuangchong commented on pull request #3918:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3918#issuecomment-709707811


   @lgcareer 
   Are you talking about direct calls via API or via web?
   
   Called via web, each click of the update button in dag.vue will trigger the 
method in udp.vue to call the backend 
verifyProcessDefinitionName(projects/${state.projectName}/process/verify-name)
   
![image](https://user-images.githubusercontent.com/37063904/96208870-000dfc80-0fa1-11eb-8c3c-6bc2fae336d1.png)
   
   In fact, when you click the update button, you can also see that you first 
request 
verifyProcessDefinitionName(projects/${state.projectName}/process/verify-name) 
in the browser console
   In request 
updateProcessDefinition(projects/${state.projectName}/process/update)
   
![image](https://user-images.githubusercontent.com/37063904/96209135-888c9d00-0fa1-11eb-9146-640d747f942a.png)
   
![image](https://user-images.githubusercontent.com/37063904/96209239-b376f100-0fa1-11eb-800c-dac29f43dbd6.png)
   
   If you call the API directly, you need to consider that there are two 
methods that have been validated for the workflow definition name. How to 
design better
   
   ---
   
   你说的是API方式直接调用还是通过web方式来调用？
   
   
通过web方式调用，在dag.vue里面每次点击更新按钮会触发udp.vue里面的方法调用后端verifyProcessDefinitionName(projects/${state.projectName}/process/verify-name)
   
![image](https://user-images.githubusercontent.com/37063904/96208870-000dfc80-0fa1-11eb-8c3c-6bc2fae336d1.png)
   
其实在点击更新按钮的时候，在浏览器控制台也可以看见先请求verifyProcessDefinitionName(projects/${state.projectName}/process/verify-name)
  
   在请求updateProcessDefinition(projects/${state.projectName}/process/update)
   
![image](https://user-images.githubusercontent.com/37063904/96209135-888c9d00-0fa1-11eb-9146-640d747f942a.png)
   
![image](https://user-images.githubusercontent.com/37063904/96209239-b376f100-0fa1-11eb-800c-dac29f43dbd6.png)
   
   如果是直接调用API方式，就需要考虑一下目前是存在两个方法都进行了工作流定义名称验证，如何更好的设计
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to