CalvinKirs commented on pull request #3718: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3718#issuecomment-716116861
Failed condition 14.2% 14.2% Coverage on New Code (is less than 33%) Failed condition 3.8% Condition Coverage on New Code (is less than 33%) > @dailidong @qiaozhanwei > > This PR is just to solve the naming modification of the ProcedureTask package. The processdure is changed to procedure. When the test class is added,it is found DriverManager.getConnection() can't mock.So SonarCloud Code Analysis checks were not successful. > > 此PR只是解决ProcedureTask程序包的命名修改，processdure 更改为 procedure，在添加测试类时，发现 > DriverManager.getConnection() 不能模拟.所以SonarCloud Code Analysis 检查不成功 You can simulate the database connection in the form of mock. In addition, the reason why sonar fails is that the coverage rate of single test is not enough, and at the same time, there is too much redundant code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
