zhuangchong commented on a change in pull request #3949:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3949#discussion_r513146404
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java
##########
@@ -177,12 +172,11 @@ public Result queryTenantlist(@ApiIgnore
@RequestAttribute(value = Constants.SES
public Result updateTenant(@ApiIgnore @RequestAttribute(value =
Constants.SESSION_USER) User loginUser,
@RequestParam(value = "id") int id,
@RequestParam(value = "tenantCode") String
tenantCode,
- @RequestParam(value = "tenantName") String
tenantName,
@RequestParam(value = "queueId") int queueId,
@RequestParam(value = "description", required =
false) String description) throws Exception {
- logger.info("login user {}, updateProcessInstance tenant, tenantCode:
{}, tenantName: {}, queueId: {}, description: {}",
- loginUser.getUserName(), tenantCode, tenantName, queueId,
description);
- Map<String, Object> result = tenantService.updateTenant(loginUser, id,
tenantCode, tenantName, queueId, description);
+ logger.info("login user {}, updateProcessInstance tenant, tenantCode:
{}, queueId: {}, description: {}",
+ loginUser.getUserName(), tenantCode, queueId, description);
Review comment:
logger.info("login user {}, updateProcessInstance tenant, tenantCode:
{}, queueId: {}, description: {}",
StringUtils.replaceNRTtoUnderline(loginUser.getUserName()),
StringUtils.replaceNRTtoUnderline(tenantCode),
queueId,
StringUtils.replaceNRTtoUnderline(description));
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java
##########
@@ -90,12 +88,11 @@
@ApiException(CREATE_TENANT_ERROR)
public Result createTenant(@ApiIgnore @RequestAttribute(value =
Constants.SESSION_USER) User loginUser,
@RequestParam(value = "tenantCode") String
tenantCode,
- @RequestParam(value = "tenantName") String
tenantName,
@RequestParam(value = "queueId") int queueId,
@RequestParam(value = "description", required =
false) String description) throws Exception {
- logger.info("login user {}, create tenant, tenantCode: {}, tenantName:
{}, queueId: {}, desc: {}",
- loginUser.getUserName(), tenantCode, tenantName, queueId,
description);
- Map<String, Object> result = tenantService.createTenant(loginUser,
tenantCode, tenantName, queueId, description);
+ logger.info("login user {}, create tenant, tenantCode: {}, queueId:
{}, desc: {}",
+ loginUser.getUserName(), tenantCode, queueId, description);
Review comment:
logger.info("login user {}, create tenant, tenantCode: {}, queueId: {},
desc: {}",
StringUtils.replaceNRTtoUnderline(loginUser.getUserName()),
StringUtils.replaceNRTtoUnderline(tenantCode),
queueId,
StringUtils.replaceNRTtoUnderline(description));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
