qiaozhanwei commented on a change in pull request #4015:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4015#discussion_r521781677
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
##########
@@ -499,7 +499,13 @@ public String buildParameter(DbType type, String host,
String address = buildAddress(type, host, port, connectType);
Map<String, Object> parameterMap = new LinkedHashMap<String,
Object>(6);
- String jdbcUrl = address + "/" + database;
+ String jdbcUrl;
+ if (DbType.SQLSERVER == type) {
+ jdbcUrl = address + ";databaseName=" + database;
+ } else {
+ jdbcUrl = address + "/" + database;
+ }
+
if (Constants.ORACLE.equals(type.name())) {
Review comment:
agree with @gabrywu idea . but this modify maybe involved not only
DbType . suggest again submit a new PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
