Eights-Li commented on pull request #4036: URL: https://github.com/apache/incubator-dolphinscheduler/pull/4036#issuecomment-728651823
> > > Overall, there seems to be no problem. > > > But there are two suggestions: > > > 1: In the parameter construction, I think there is no need to use linkedList, the original StringBuilder may be better. > > > 2: It is recommended not to use values in the enum. The recommended approach is to put the enumeration value in a static constant. > > > > > > 1 The purpose of using linkedlist is not to splice a large number of spaces in stringbuilder > > 2 the enum value in a static constant seems a good idea > > I understand what you mean, you first use LinkedList, and finally use StringUtils.join(StringBuilder). In my opinion, it is better to use StringBuilder directly, which is more efficient. What do you think. Yes, in terms of efficiency, stringbuilder is more efficient than StringUtils.join. I will remove linkedList and use StringBuilder ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
