chengshiwen opened a new pull request #4162:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4162


   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *fix re-login problem in new tab*
   
   ## Brief change log
   
   *fix re-login conditional logic in 
dolphinscheduler-ui/src/js/module/io/index.js*
   
   the new re-login condition is `(!sIdCookie || (sessionId && sessionId !== 
sIdCookie)) && requstUrl !== 'login'`
   
   assume `requstUrl !== 'login'`:
   
   - `sIdCookie` is `undefined` or `null`: require re-login
   - `sessionId && sessionId !== sIdCookie`: require re-login when sessionId 
changed
     - attention that `sessionId` may be `null` but `sIdCookie` is non-empty
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   **Before fix**:
   ![image](https://sc02.alicdn.com/kf/H70e4479954f04f60ab64347e38a3bc0ar.jpg)
   
   **After fix**:
   ![image](https://ae04.alicdn.com/kf/Hb6d9c22a80f846ea8f3e18cd558f3fbeL.jpg)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to