CalvinKirs commented on pull request #4164: URL: https://github.com/apache/incubator-dolphinscheduler/pull/4164#issuecomment-738814354
Hi, you also need to provide UT for verification of this change. In addition, I saw sonar's report that there is a D-level code smell, and you should also resolve it. You can click to view it directly, sonar will give you corresponding suggestions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
