lenboo commented on a change in pull request #4182:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4182#discussion_r539357144
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java
##########
@@ -155,14 +169,17 @@ public CommandExecuteResult run(String execCommand)
throws Exception{
// parse process output
parseProcessOutput(process);
-
Integer processId = getProcessId(process);
result.setProcessId(processId);
// cache processId
taskExecutionContext.setProcessId(processId);
-
taskExecutionContextCacheManager.cacheTaskExecutionContext(taskExecutionContext);
+ boolean updateTaskExecutionContextStatus =
taskExecutionContextCacheManager.updateTaskExecutionContext(taskExecutionContext);
+ if (Boolean.FALSE.equals(updateTaskExecutionContextStatus)) {
+ ProcessUtils.kill(taskExecutionContext);
+ result.setExitStatusCode(EXIT_CODE_KILL);
Review comment:
whether here need return the result too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
