chengshiwen opened a new pull request #4214:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4214


   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review 
https://dolphinscheduler.apache.org/en-us/community/index.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   *Add UI eslint support with .js and .vue files for better code quality and 
fewer bugs*
   
   ## Brief change log
   
    - **support auto eslint for .js, .vue file on save**
    - fix ui eslint syntax by npm run lint
    - fix eslint: assigned a value but never used
    - fix eslint: expected '!==' but instead saw '!=', expected '===' but 
instead saw '=='
    - fix: eslint errors manually
    - fix eslint: Unexpected side effect in cacheParams computed property
    - fix eslint: comment rule 'vue/no-mutating-props' so that solve 
'unexpected mutation of prop' error later
      - **only 'unexpected mutation of prop' error remain, which needs more 
time to check and fix** 
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   **In the past:**
   There are many warnings and errors in 144 files under eslint, and some of 
these problems will lead to unexpected bugs, for examples:
   
![image](https://user-images.githubusercontent.com/4902714/101901713-70757a80-3bec-11eb-960b-0064380cc2ba.png)
   
![image](https://user-images.githubusercontent.com/4902714/101901081-7a4aae00-3beb-11eb-9579-c38ddea718c6.png)
   
![image](https://user-images.githubusercontent.com/4902714/101901316-d57ca080-3beb-11eb-8d9c-69d22e718efe.png)
   
![image](https://user-images.githubusercontent.com/4902714/101901489-11176a80-3bec-11eb-9b45-e3de9f0bb6e8.png)
   
   **Now:**
   **Only 'unexpected mutation of prop' error remain in 9 files, which needs 
more time to check and fix**
   
![image](https://user-images.githubusercontent.com/4902714/101901948-d4983e80-3bec-11eb-8b9a-7ab31bee7d21.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to