lgcareer commented on a change in pull request #4164:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4164#discussion_r543000781



##########
File path: 
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/DolphinSchedulerManager.java
##########
@@ -78,6 +78,13 @@ public void initDolphinSchedulerSchema() {
 
         logger.info("Start initializing the DolphinScheduler manager table 
structure");
         upgradeDao.initSchema();
+        //create directories in the sql/create to store the multiple upgrade 
mirrors
+        try {
+            UpgradeDao.createMirrorDirs();

Review comment:
       I think you've done much better this time than you did last time.Now you 
only need design the ddl and dml under sql/create,where the file of mirror ddls 
and dmls come from?You can see the example of existed files of sql/createm.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to