dailidong commented on pull request #4299:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4299#issuecomment-758386182


   > What part should I split into another PR. The test coverage needs to be 
increased to at least 33% to pass sonar check. Should I leave test coverage out 
of this PR?
   
   you can split it according the module, like 
dolphinscheduler-alert、dolphinscheduler-api and so on.  just remember don't 
includes too many files in one PR. because review these files will be difficult 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to