IamMujuziMoses commented on a change in pull request #4411:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4411#discussion_r555975888
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -18,6 +18,7 @@
package org.apache.dolphinscheduler.api.service.impl;
import static
org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID;
+import static org.apache.dolphinscheduler.dao.upgrade.UpgradeDao.getDataSource;
Review comment:
This is not needed
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -73,6 +74,7 @@
import org.apache.dolphinscheduler.service.permission.PermissionCheck;
import org.apache.dolphinscheduler.service.process.ProcessService;
+import javax.sql.DataSource;
Review comment:
this too is not neeeded
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -122,6 +124,8 @@
private static final String TASKS = "tasks";
+ protected static final DataSource dataSource = getDataSource();
Review comment:
This too is not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
