CalvinKirs commented on a change in pull request #4453:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4453#discussion_r557817027
##########
File path: pom.xml
##########
@@ -924,49 +923,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.apache.rat</groupId>
- <artifactId>apache-rat-plugin</artifactId>
- <version>${apache.rat.version}</version>
- <configuration>
- <excludeSubProjects>false</excludeSubProjects>
-
<addDefaultLicenseMatchers>false</addDefaultLicenseMatchers>
- <licenses>
- <license
implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
- <licenseFamilyCategory>AL20</licenseFamilyCategory>
- <licenseFamilyName>Apache License,
2.0</licenseFamilyName>
- <patterns>
- <pattern>Licensed to the Apache Software
Foundation (ASF)</pattern>
- </patterns>
- </license>
- </licenses>
- <licenseFamilies>
- <licenseFamily
implementation="org.apache.rat.license.SimpleLicenseFamily">
- <familyName>Apache License, 2.0</familyName>
- </licenseFamily>
- </licenseFamilies>
- <excludes>
- <exclude>**/node_modules/**</exclude>
- <exclude>**/node/**</exclude>
- <exclude>**/dist/**</exclude>
- <exclude>**/licenses/**</exclude>
- <exclude>.github/**</exclude>
- <exclude>**/sql/soft_version</exclude>
- <exclude>**/common/utils/ScriptRunner.java</exclude>
- <exclude>**/*.json</exclude>
- <!-- document files -->
- <exclude>**/*.md</exclude>
- <excldue>**/*.MD</excldue>
- <exclude>**/*.txt</exclude>
- <exclude>**/docs/**</exclude>
- <exclude>**/*.babelrc</exclude>
- <exclude>**/*.eslint*</exclude>
- <exclude>**/.mvn/jvm.config</exclude>
- <exclude>**/.mvn/wrapper/**</exclude>
- </excludes>
- <consoleOutput>true</consoleOutput>
- </configuration>
- </plugin>
Review comment:
Would it be better to keep the rat plugin? It can help us to conduct
self-checks more conveniently in the development environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
