chengshiwen commented on a change in pull request #4529:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4529#discussion_r562411380



##########
File path: .gitignore
##########
@@ -4,43 +4,41 @@
 .zip
 .gz
 .DS_Store
+.target
 .idea/
-dist/
-all-dependencies.txt
-self-modules.txt
-third-party-dependencies.txt

Review comment:
       Because the dev branch has remove these lines, I just keep same with it 
and plan merge into dev and avoid conflicts

##########
File path: .gitignore
##########
@@ -4,43 +4,41 @@
 .zip
 .gz
 .DS_Store
+.target
 .idea/
-dist/
-all-dependencies.txt
-self-modules.txt
-third-party-dependencies.txt

Review comment:
       Because the dev branch has remove these lines, I just keep same with it 
and plan to merge this code into dev and avoid conflicts

##########
File path: .gitignore
##########
@@ -4,43 +4,41 @@
 .zip
 .gz
 .DS_Store
+.target
 .idea/
-dist/
-all-dependencies.txt
-self-modules.txt
-third-party-dependencies.txt

Review comment:
       Already restored




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to