[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4543: [FIX-2101]It solves the problem that the name of the branch will not change after the name of the branch is changed in the workflow page and instance page.

[GitBox]

lenboo commented on a change in pull request #4543:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4543#discussion_r563310657



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -460,6 +460,58 @@ private void addDependResultForTaskList(List<TaskInstance> 
taskInstanceList) thr
             if (tenant != null) {
                 processInstance.setTenantCode(tenant.getTenantCode());
             }
+            // get the processinstancejson before saving,and then save the 
name and taskid
+            String oldJson = processInstance.getProcessInstanceJson();

Review comment:
       duplicate code can be extracted to method in ProcessService

##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -460,6 +460,58 @@ private void addDependResultForTaskList(List<TaskInstance> 
taskInstanceList) thr
             if (tenant != null) {
                 processInstance.setTenantCode(tenant.getTenantCode());
             }
+            // get the processinstancejson before saving,and then save the 
name and taskid
+            String oldJson = processInstance.getProcessInstanceJson();

Review comment:
       duplicate code can be extracted to a method in ProcessService




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org