lenboo commented on a change in pull request #4555:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4555#discussion_r564363214



##########
File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/conditions/ConditionsParameters.java
##########
@@ -78,4 +78,11 @@ public void setSuccessNode(List<String> successNode) {
     public void setFailedNode(List<String> failedNode) {
         this.failedNode = failedNode;
     }
+
+    public String toJsonString() {

Review comment:
       you do not need toJsonString here. The JsonUtils already have this 
function.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to