lenboo commented on a change in pull request #4555:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4555#discussion_r565786427
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -459,6 +459,12 @@ private void addDependResultForTaskList(List<TaskInstance>
taskInstanceList) thr
if (tenant != null) {
processInstance.setTenantCode(tenant.getTenantCode());
}
+ // get the processinstancejson before saving,and then save the
name and taskid
+ String oldJson = processInstance.getProcessInstanceJson();
+ ProcessData oldProcessData = JSONUtils.parseObject(oldJson,
ProcessData.class);
+ if (oldProcessData != null) {
Review comment:
in order to reduce the complexity here, this null judge can be put into
the ’changeJson‘
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
