597365581 commented on a change in pull request #4618:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4618#discussion_r566540904
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java
##########
@@ -348,12 +348,14 @@ public void run() {
long lastFlushTime = System.currentTimeMillis();
- while ((line = inReader.readLine()) != null) {
+ while ((line = inReader.readLine()) != null ||
logBuffer.size() > 0) {
Review comment:
If line is null check logBuffer.size()>0 ，so lastFlushTime =
flush(lastFlushTime); can have a chance to exec. old code while ((line =
inReader.readLine()) != null) cause lastFlushTime = flush(lastFlushTime);
have no chance to exec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
