zhuangchong commented on a change in pull request #4645:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4645#discussion_r569167312
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -129,9 +134,20 @@ private void runSender() {
if (alertPluginManager == null ||
alertPluginManager.getAlertChannelMap().size() == 0) {
logger.warn("No Alert Plugin . Can not send alert info. ");
} else {
- List<Alert> alerts = alertDao.listWaitExecutionAlert();
- alertSender = new AlertSender(alerts, alertDao,
alertPluginManager);
- alertSender.run();
+ InterProcessMutex mutex = null;
+ try {
+ logger.error("创建分布式锁 : ");
+ mutex = zookeeperClient.getAlertLockPath();
+ mutex.acquire();
+ List<Alert> alerts = alertDao.listWaitExecutionAlert();
+ alertSender = new AlertSender(alerts, alertDao,
alertPluginManager);
+ alertSender.run();
+ } catch (Exception e) {
+ logger.error("alert server with error : ", e);
+ } finally {
+ zookeeperClient.release(mutex);
+
+ }
Review comment:
Please add the design of synchronous alerts, which is currently used by
SQL task nodes
---
请添加同步告警的设计，目前sql任务节点使用的是同步告警方式
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
