WilliamChen-luckbob edited a comment on issue #4696:
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/4696#issuecomment-774810962


   
   > Do you mean, input in the form of JOSN string, and then we automatically 
parse it into the form of K-V?
   
   
   @CalvinKirs 
   Nope, sorry that English is not my first language and that may lead to some 
misuderstanding.
   
   To input in the form of JOSN string, and then DolphinScheduler automatically 
parse it into the form of K-V is only a convenient way for us to set start 
parameters.
   
   I can also generate the K-V pairs before I call the StartNewProcessInstance 
api.
   
   The primary point is:
   
   I think that in some cases, tasks accept not only form-data in  K-V pair, 
but also accept form-data in K-JSON pair.
   e.g. 
   ProcessDefinition api(/dolphinscheduler/projects/{projectName}/process/save)
   This api accepts form-data parameter which can directly input JSON string.
   
   Tasks in the ProcessInstance may have the same situation.
   
   But when I'm trying to send a start parameter (K in string, V in JSON 
string) , it leads to the exception.
   
   Now DolphinScheduler can only accept (K in string,V in string). When I input 
start parameters(K in string, V in JSON string), Jackson will report an 
exception that cannot transform to Map<String,String>.
   
   And if we chose to get parameters by using Map<String,Object>, I think and 
also tried, Jackson will not report such exception.
   
   And that was what I mean.
   
   
   By the way, here are some new ideas I came out this weekend while using 
DolphinScheduler showing below:
   
   1. After starting a new ProcessInstance it would be better to return the 
Istance ID of this Instance so that we can quickly bind the instance ID to the 
options of our own system which using DolphinScheduler as a scheduler 
structure. Otherwise, it is quite confuzed when we are trying to achive 
Instance log.
   
   2. Also I think the way of how to share parameters between tasks in Azkaban 
is quite a good idea. The Same way as DolphinScheduler, but they support more 
situations.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to