chengshiwen commented on a change in pull request #4739:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4739#discussion_r572614704
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
##########
@@ -298,8 +298,12 @@ private void resultProcess(ResultSet resultSet) throws
Exception {
String result = JSONUtils.toJsonString(resultJSONArray);
logger.debug("execute sql : {}", result);
- sendAttachment(sqlParameters.getGroupId(),
StringUtils.isNotEmpty(sqlParameters.getTitle()) ? sqlParameters.getTitle() :
taskExecutionContext.getTaskName() + " query result sets",
- JSONUtils.toJsonString(resultJSONArray));
+ try {
+ sendAttachment(sqlParameters.getGroupId(),
StringUtils.isNotEmpty(sqlParameters.getTitle()) ? sqlParameters.getTitle() :
taskExecutionContext.getTaskName() + " query result sets",
+ JSONUtils.toJsonString(resultJSONArray));
+ } catch (Exception e) {
Review comment:
A few days ago, Chenxingchun and I tested it and found the `execute sql
error`, and we both felt weird besides the issue #4621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
