CalvinKirs commented on a change in pull request #4752:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4752#discussion_r574204693
##########
File path:
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessInstance.java
##########
@@ -202,7 +202,7 @@
* @return
*/
@TableField(exist = false)
- private Long duration;
+ private String duration;
Review comment:
hi, should we separate this and create different beans?
It is not recommended to use one for DO, DTO, and VO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
