chengshiwen commented on issue #3369: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3369#issuecomment-777171056
> > @CalvinKirs I have resolved all the related PRs by yangyichao-mango. > > I noticed that there are some code smells in the pr you submitted, it is best to solve them. (Some may not be a real bad code smell) @CalvinKirs Those code smells already exist in the previous code, and are not introduced by me. I have tried to fix some bugs, vulnerabilities, security hotspots and code smells. Such as the previous pr #3440, you can see 2 vulnerabilities, 1 security hotspot and 34 code smells, while in the new pr #4759, there are only 27 code smells. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
