[GitHub] [incubator-dolphinscheduler] WilliamChen-luckbob commented on a change in pull request #4779: [Fix] while repeat running, the global parameters will not set to the user specified start parameters.

Thu, 18 Feb 2021 20:34:33 -0800 


WilliamChen-luckbob commented on a change in pull request #4779:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4779#discussion_r578919390



##########
File path: 
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -575,23 +596,6 @@ private ProcessInstance 
generateNewProcessInstance(ProcessDefinition processDefi
                 }
             }
         }
-

Review comment:
       @CalvinKirs 
   Sure, that piece of code was rolled back to it's origin status.
   Only those which related to repeat running were changed.
   
   
![image](https://user-images.githubusercontent.com/58684828/108458003-ab5ff280-72ae-11eb-96e5-bdcf9a4a1237.png)
   Also, I have tested recover failed function of a process instance, the same 
problem occured as this issue.
   I'm going to fix this bug too.
   Should I create another issue to report this situation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to