felix-thinkingdata commented on a change in pull request #4802:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4802#discussion_r578923099
##########
File path:
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/DateUtilsTest.java
##########
@@ -196,4 +196,12 @@ public void testFormat2Duration() {
}
+ @Test
+ public void testNullDuration() {
+ // days hours minutes seconds
+ Date d1 = DateUtils.stringToDate("2020-01-20 11:00:00");
+ Date d2 = null;
+ Assert.assertEquals("",DateUtils.format2Duration(d1,d2));
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]