simon824 commented on a change in pull request #4828:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4828#discussion_r579902366
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -427,9 +427,6 @@ private String getResourceIds(ProcessData processData) {
return result;
}
}
- // get the processdefinitionjson before saving,and then save the name
and taskid
- String oldJson = processDefinition.getProcessDefinitionJson();
- processDefinitionJson = processService.changeJson(processData,
oldJson);
ProcessData newProcessData =
JSONUtils.parseObject(processDefinitionJson, ProcessData.class);
Review comment:
parse processDefinitionJson to ProcessData is duplicated with line405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
